Display ingested file paths instead of file names #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omartrigui
changed the title
|
Personally this would break my use case for PGPT for me. Almost all of my items are web URLS. So the "filename" is actually the URL of a confluence page, web article, policy, etc... This PR would not work with how I use PGPT. Not sure how others feel, but I think this should be a toggleable (Off by default) setting. IMO. |
|
+1 for an option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation only displays the ingested filenames, which can be confusing for users when the specified directory for ingestion contains nested directories with multiple levels. Additionally, the existing implementation discards files with different names e.g. a root_path directory contains index.md, dir1/index.md, dir2/index.md, only one single
index.mdfile is displayed. This PR enhances the display by including the file paths instead of just filenames, addressing the potential confusion caused by nested directories, and ensures that all files are appropriately displayed without discarding any.Fix preview